javalin / javalin

A simple and modern Java and Kotlin web framework

Home Page:https://javalin.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Compatibility with Jetty 12

mvysny opened this issue · comments

Describe the feature
Hi, I'm running Jetty 12.0.6, and unfortunately Javalin fails to start in such environment:

Caused by: java.lang.NoSuchMethodError: 'java.util.Map org.eclipse.jetty.http.MimeTypes.getInferredEncodings()'
	at io.javalin.jetty.JettyServer.<init>(JettyServer.kt:39)
	at io.javalin.Javalin.lambda$new$0(Javalin.java:39)
	at io.javalin.util.Util$createLazy$1.invoke(Util.kt:25)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at io.javalin.Javalin.create(Javalin.java:75)
	at com.example.MyJavalinServlet.<init>(MyJavalinServlet.kt:14)

Would it be possible to add support for Jetty 12 please?

Additional context

The reason is that in jetty-http 11 the MimeTypes class included the getInferredEncodings() method while in jetty-http 12 the method is missing.

Javalin 6.1.2

Oops, sorry, I just noticed #2067 .

Oddly enough, Javalin 5 works with Jetty 12 while Javalin 6 doesn't.

Would it be possible to add support for Jetty 12 please?

@mvysny, can't really do that without breaking 6x, but Javalin 7 will be Jetty 12.

Perfect, thank you @tipsy