Move javalin-rendering back into main repo
tipsy opened this issue · comments
I'm asking because I'm getting if this fails, you need to run mvn gg.jte:jte-maven-plugin:generate first, and I don't really want to burden the average person trying to build the main repo with this task.
I think I can just disable it, and we can run it manually 🤔
Even with running mvn gg.jte:jte-maven-plugin:generate I was not able to get the Kotlin tests to pass:
I think it depends what you want to optimize for. So far we already had all possible ways to run these tests.
- We started with on demand compiled templates, which is easy to use and does not require a build step. I think the complaint about this mode, that it took some time to run the compile step.
- Next step was, that we precompiled the templates, committed the precompiled templates and loaded these for the test. This fixed the extra compile time and was still easy to use without a build step. If I remember correctly, the complaint about this mode was, that it did not test the integration with maven (javalin/javalin-rendering#22)
- Now we're here :-)
Sounds like it's been a journey 😄
I'm guessing this first complaint was when the templates were part of the javalin artifact (?). Could you help me move it back to on-demand-compilation?
I think so yes. And sure! I think going back to the original version here should do the trick: #1240
Thanks !