java-diff-utils / java-diff-utils

Diff Utils library is an OpenSource library for performing the comparison / diff operations between texts or some kind of data: computing diffs, applying patches, generating unified diffs or parsing them, generating diff output for easy future displaying (like side-by-side view) and so on.

Home Page:https://java-diff-utils.github.io/java-diff-utils/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add module-info.java to library

cowwoc opened this issue · comments

Please add module-info.java to this library. At first glance, the following content should do:

module io.github.javadiffutils
{
  exports com.github.difflib;
  exports com.github.difflib.patch;
}
commented

At the moment this project is build using Java 8. So I would not be able to build it including this module stuff.

@wumpz You can release a single JAR file that works for both Java 8 and newer versions of Java simultaneously.

See https://www.baeldung.com/maven-multi-release-jars as an example, using multiReleaseOutput for the Java9+ section.

Stale issue message

This issue still exists.

Sure but as mentioned above at the moment no module-info.java will be added. However using mavens jar plugin the automatic module name is set:

 <Automatic-Module-Name>io.github.javadiffutils</Automatic-Module-Name>

@wumpz Did you read the part where I explained you could add module-info.java while maintaining JDK 8 support?

@cowwoc I read it, but I am no fan of this multi version jars. If I upgrade to a higher Java version, this will definitly included, but not now.