jasonrudolph / keyboard

⌨ Toward a more useful keyboard

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Escape sent after control+click

bkeepers opened this issue · comments

control+click on a Mac will bring up the right click menu. Since c0e915b, escape is sent when releasing the control key, regardless of how long control was held for, which will close any menu that comes up.

Expected behavior:

Escape key is only sent if control is quickly tapped and released.

Steps to reproduce:

  1. control+click on this page
  2. Release control once the menu appears
  3. See menu disappear

Checking out c0e915b8^ will revert to the expected behavior.

cc @landongrindheim

Thanks for the heads up @bkeepers! Looks like I introduced a naming conflict in that commit 😓. #51 has been opened to fix this 😄