jasonmimick / atlas-osb

DEPRECATED: See https://github.com/mongodb/atlas-osb

Home Page:https://github.com/mongodb/atlas-osb

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow advanced cluster backup configuration

jasonmimick opened this issue · comments

allow for plans to update certain backup configuration changes.
Maps to Manulife - Use case 7:   As a user I should be able to configure PIT for my cluster (Sprint 3/4?)

See:
https://docs.atlas.mongodb.com/backup/cloud-backup/overview/

What works already:

cluster:
  ...
  providerBackupEnabled: true
  pitEnabled: true

What does not, but is supported by the Atlas client:

  • Managing backup schedule

We should be able to add this in a similar fashion we did with Project creation. A new CloudProviderSnapshotBackupPolicy field in Plan should do the trick - most of the logic is already there

Ok, so will it be like this in general:

For a plan,

project:
  name:
...
cluster:
  name:
  ...
cloudProviderSnapshotBackupPolicy:
  name:
  ...

This should be ok, but we need to handle multiple CloudProviderSnapshotBackupPolicy's (and multiple NetworkPeering, etc, for all resources like this).
Checking over in the go client though, seems there is only Update for one policy, so if we document properly we can maybe not deal with multiple backup policies. https://github.com/mongodb/go-client-mongodb-atlas/blob/7f72d26915c748762bdcf3f704f8d212862309be/mongodbatlas/cloud_provider_snapshot_backup_policies.go#L81

Given that the configuration and management of these backup policies is outside the basic scope of OSB/provision/bind workflow, we recommend that we NOT use the broker to manager these settings.
Rather, directly managing in the UI or through the API would be best - we can provide technical assistance if needed.

If this ok, we will close this issue as "out of scope" for the broker.

Thanks-

I believe this backup enhancement needs to be in the broker. While users won’t necessarily be using the broker to change/edit the backup policies, we do want to have a standard/default set of backup policies apply for every service instance creation. If we can somehow change the default on the atlas management website, that would be acceptable as well.