jasny / sso

Simple Single Sign-On for PHP

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong implementation of setcookie

rauwebieten opened this issue · comments

commented

The signature of setcookie is not correctly used in Broker/Cookies.php line 48 and 62

$success = setcookie($name, $value, time() + $this->ttl, $this->domain, $this->path, $this->secure, true);

Should be (path and domain changed)

$success = setcookie($name, $value, time() + $this->ttl, $this->path, $this->domain, $this->secure, true);

This was fixed on master, but no new version was released since. I've released v0.4.1