Missing peer dependency definition in package.json

Question

Missing peer dependency definition in package.json

flq opened this issue 6 years ago · comments

In trying to figure out how much this package would add to bundle size, bundlephobia was unable to check this, since

MissingDependencyError
This package (or this version) uses `react`, but does not specify them either as a dependency or a peer dependency

Wouldn't it make sense to define said peer dependency?

stale · Answer 1 · Sat Dec 01 2018 00:35:27 GMT+0800 (China Standard Time)

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

stale · Answer 2 · Sat Dec 08 2018 01:32:15 GMT+0800 (China Standard Time)

Closed due to inactivity. Holler if this is a mistake, and we'll re-open it.

Frank Quednau · Answer 3 · Sat Dec 08 2018 01:53:08 GMT+0800 (China Standard Time)

What activity do you want? One just needs to answer with yes or no whether one shouldn’t state react as peer dependency.