jaredhanson / passport-http

HTTP Basic and Digest authentication strategies for Passport and Node.js.

Home Page:https://www.passportjs.org/packages/passport-http/?utm_source=github&utm_medium=referral&utm_campaign=passport-http&utm_content=about

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Passwords containing ':' are not read properly

Cybolic opened this issue · comments

Since userid and password are read as index 0 and 1 of credentials.split(':') the remaining part of the password after ':' is discarded.

So... over a year and nobody else seems to care about this? This is tripping us up. Can we please merge the PR? #42

For anybody else who needs to fix this now, just URL encode your password on the client and then decode it on the server. Maybe we should suggest that in the docs?

go and merge!

Please merge #42 - this is a blocker for us, thanks!

Duplicate of #20