Depends on passport ~0.1.3
nickcmaynard opened this issue · comments
Really rather out of date now. This means that passport-http currently picks up passport#0.1.18.
Suggest we update this to be current.
+1 to this
Turns out this might have a nasty side-effect - passport/lib/http/request.js always augments the req prototype, regardless of whether it's already augmented.
This means an up-to-date passport's newer login and logout functions get blown away by old versions when passport-http gets pulled in.
I'd suggest an approach similar to that which passport-local takes with dependencies to fix this:
jaredhanson/passport-local@3a2c375
Indeed, this would help too - replace the dependency with passport-strategy jaredhanson/passport-local@980d67d.
I'll take a look at this and see if I can throw together a PR.
Holding fire on that PR - looks like we have a number of competing issues/PRs for the same sort of thing. Julson's work in #35 looks pretty good, so I'd suggest we concentrate on that.
Fixed by merging #35.