passReqToCallback slightly inconsistent with Express, doc update?
dgolant opened this issue · comments
Hi,
I just dealt with a minor annoyance for an hour, figured I would share in case it was valuable for docs. When passing the passReqToCallback
argument to a strat, the "incoming" query params are accessible through req.params
. In Express, query params come through on req.query
. In the callback/handler in the google strategy, req.query
stores a state
and code
key, which makes it seem as though req.query
is being overwritten even when passReqToCallback
is true. Happy to update docs as long as this confusion isn't based solely in my own denseness 👍 .
Actually, I am not sure what I did (or if it ever worked, was tired when I did this), but this no longer even works for me. If I set passReqToCallback: true
on the strategy, query
comes through with state
and code
, but req.params
comes through empty.