Giters

janus-idp / helm-backstage

Helm Chart for Deploying Backstage. This repo is deprecated. Please move to https://github.com/redhat-developer/rhdh-chart

Home Page:https://redhat-developer.github.io/rhdh-chart/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question: Why another helm chart project ?

cmoulliard opened this issue · comments

commented

Question

As a backstage initiative project already exists, I'm wondering why you created another helm chart project ?

https://github.com/vinzscam/backstage-chart
backstage/backstage#4945

Remark: That would be great to unify the 2 existing helm charts !

commented

@cmoulliard @froblesmartin This chart exists as there is no existing centralized Helm chart for deploying backstage. There have been some discussions as in backstage/backstage#4945 on a centralized location.

I'd be happy to collaborate with the community on providing a unified helm chart that takes the best of all implementations thus far

commented

@sabre1041 @vinzscam could you sync? :)

this is great @sabre1041, nice work! Definitely, let's sync all together in discord.

commented

It might be a wider scope. Admittedly the more people use a common chart the more switching can be unified.

Recently our generic kubernetes chart (homegrown) was updated to support openshift. Which resulted in a interim refactor of:

-f resource-dev/prod/?.yaml -f default-app-config.yaml -f openshift-values.yaml -f values.yml

where openshift-values.yaml had a lot of securityContext switching vs vanilla.

commented

Currently awaiting Discord phone timeouts before I get back into my account. I shall be on the relevant channels soon 👍

commented

I see another helmchart recently opensourced for backstage - https://github.com/backstage/charts

commented

I think this is the one that will be used going forward. @vinzscam created it so I'm assuming it's the one that was hosted under his profile that a couple of us contribute to 👍 . We always expected it to be transferred over to the official backstage repo at some point.

commented

Yes! You can see that added as a deprecation notice in the old repo: vinzscam/backstage-chart@0d864f1

commented

If the new home is going to be https://github.com/backstage/charts shouldn't this repo be deprecated as well?

commented

Thank you for this discussion! As you can see, situation changed over time and from the time of "there's no proper Helm chart around that is robust enough" (aka the time when this repo was created) we got to a point when we have a solid and stable upstream helm chart at https://github.com/backstage/charts

The upstream chart is very versatile, maintained and overall in a good shape. However due to it's nature of a truly upstream chart, it does not feature platform specific integrations we strive for in Janus. Therefore we should repurpose this chart and make it so it:

  1. Respects and uses the upstream chart.
  2. Provide OpenShift specific capabilities like support for Routes and S2I builds via BuildConfig, etc.

I propose following plan:

  1. Remove the current chart from the repo
  2. Create a new one that would list the upstream chart as a Helm dependency. (If we choose the new chart to use the same name as the current one, we introduce this as a breaking change by changing the MAJOR semver).
  3. Provides sane default values for deployment on OpenShift
  4. Extends the chart with capabilities mentioned above

Please let me know what you think.

commented

@tumido agree with you that the upstream chart has matured nicely since the impetus of the chart effort in the Janus project. I also (strongly) agree that we should extend through a dependency mechanism and not fork the upstream chart.

+1 to all the above

commented

@tumido this approach looks good to me.