Giters

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution

Home Page:https://showcase.janus-idp.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Doc] duplicated Wrapping a third-party plugin sections on Dynamic Plugins support doc

josephca opened this issue · comments

commented

What do you want to improve?

In the Dynamic Plugins support doc, minor cosmetic issue needs to be addressed.

  1. merge duplicate appearance of Wrapping a third-party plugin to add dynamic plugin support
  1. to avoid any confusion no numbering is needed for a single bullet point:

    backstage-showcase/showcase-docs/dynamic-plugins.md

    Line 229 in 44e0063

    1. To include static JSX as element children with your dynamically imported component, please define an additional export as follows and use that as your dynamic plugin `importName`:
commented

I believe for the Wrapping a third-party plugin to add dynamic plugin support sections, one is for frontend dynamic plugins and one is for backend dynamic plugins as they have slightly different wrapping processes.