Discuss whether to update dynamic plugin wrappers or merge https://github.com/janus-idp/backstage-plugins/pull/827

[Frank Kong]

What do you want to discuss?

janus-idp/backstage-plugins#910 makes dynamic wrappers for the janus backend plugins.
However, it currently utilizes both the schedule and scheduler options when creating the entity providers for the aap-backend, keycloak-backend and ocm-backend. This kind of configuration is also currently present in the wrappers in the backstage showcase.

However, since janus-idp/backstage-plugins#827 has not been merged at the moment, this would cause the entity providers to utilize the schedule option (which is hardcoded), and not allow the scheduler option (from the app-config.yaml) to override the default schedule option. Ex: keycloak default has a frequency of 1 hour, and cannot be changed.

Additionally, it was mentioned by @tumido that utilizing both schedule and scheduler was an anti-pattern we don't want to support.

We want to discuss whether we should merge janus-idp/backstage-plugins#827 or remove the default schedule provided by the schedule option. For the latter option, this would require users to provide a schedule configuration for the plugin in the app-config.yaml or else the backend would fail to start up if the plugin is enabled.

UPDATE:

• making sure that we have consistent behaviour in our dynamic plugin wrappers

[Tomas Kral]

For the latter option, this would require users to provide a schedule configuration for the plugin in the app-config.yaml or else the backend would fail to start up if the plugin is enabled.

Would it be possible to have define a default value for scheduler options in app-config.yaml ?

[Tomas Kral]

fixed in janus-idp/backstage-plugins#827