jantic / DeOldify

Currently, as far as i can see, rebuilding the video (from the colorized frames) only works if the original input video is a .mp4. (I think that is the reason for #471 as i also have a .mkv based workflow) I have a fix for this on my fork which i would be willing to split up into a PR.
However, I am not very familiar with this project so I wanted to ask if this is a desired feature and if there is any reason to blacklist or whitelist specific video formats.

Regards

PS: the culprit:

DeOldify/deoldify/visualize.py

Line 306 in 141e873

source_path.name.replace('.mp4', '_no_audio.mp4')

Yeah that's a deliberate decision. As the aim is to just make research freely available to the public, I made a few simplifying decisions to keep maintenance and bugs to a minimum. This is one of them.

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

I understand. It might be good to add a check and error message otherwise the decision does not seem too deliberate.
Anyway I will keep using my fork then, I completely understand not wanting to put effort into this.

video building only works for mp4s