fetch method on collection not returning deferred object

[Mike McKay]

I expected to get a jquery deferred object back when I call fetch on a collection - but I am getting undefined. This means I can't hook up a complete callback.

var deferred = myCollection.fetch()

deferred.complete(function(){console.log("success or error have been completed")})

[Jan Monschke]

The Backbone Collection does not return a deferred object iirc. You need to pass an object as the first parameter to get called back when the fetch has finished.

myCollection.fetch({
    success: function(){},
    error: function(){}
})

Also the Collection fires a "reset"-event when it's done loading the new models.

http://documentcloud.github.com/backbone/#Collection-fetch

[Jan Monschke]

Does that answer your question?

[Mike McKay]

That definitely helps. So for fetches done on the collection if I want to
replicate the "complete" callback I need to add the code I want to be
called to both success and error?

complete = function(){console.log("Fetching has either succeeded or failed)}

myCollection.fetch({
success: function(){complete()},
error: function(){complete()}
})

---

I was hoping to be able to do:

myCollection.fetch({
complete: function(){complete()},
})

or using the "new" deferred stuff in jquery

deferred = myCollection.fetch()
deferred.complete(complete)

or via the new deferred approach:

On Tue, Jan 10, 2012 at 3:40 PM, Jan Monschke <
[e-mail]

wrote:

Does that answer your question?

---

Reply to this email directly or view it on GitHub:

#29 (comment)

[Jan Monschke]

Unfortunately yes, because jquery.couch.js overwrites the complete-handler.

https://github.com/janmonschke/backbone-couchdb/blob/master/chat_example/_attachments/js/jquery.couch.js#L1026

But I'm working on a fix. Will post it in some minutes, stay tuned.

[Jan Monschke]

I now manually call complete for each method. That works around the problem.

[Mike McKay]

Great! That's what I ended up doing in my code. Thanks for working on this
great library and for being responsive. :-)

On Tue, Jan 10, 2012 at 4:27 PM, Jan Monschke <
[e-mail]

wrote:

I now manually call complete for each method. That works around the
problem.

---

Reply to this email directly or view it on GitHub:

#29 (comment)