janjongboom / node-native-zip

Zipping in node.js with no external dependencies

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CRC should be computed on raw data rather than compressed data

bjouhier opened this issue · comments

I added support for deflate in my fork and noticed that the CRC were wrong. They should be computed on the uncompressed data.

I could send you a pull request from my fork but I used streamline.js to simplify the async bits and I'm not sure you wanna go in this direction.

Bruno