janboddez / feed-reader

A very simple feed reader plugin for WordPress

Home Page:https://feedreader.site

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Entry added twice

janboddez opened this issue · comments

https://colly.com/stream/gordon-miller was added twice, although the content did change ever so slightly in between

Could be one of those instances where we calculate a unique ID by hashing an entry's content. Or maybe the URL changed. Haven't seen it happen again.

Happened again, same blog. The second entry had had a slight update. Likely there's no GUID and we use a hash of the content to determine is an item already exists or not.

$uid = ! empty( $entry['url'] )

Thing is we should use the link (there is a link), although I'm not 100% sure what $item->get_id() does.

Actually, I had a quick look and I think SimplePie returns either a GUID or a hash. I.e., it's ahead of us. Different hash, different entry. Not much I think we can (or should?) do.