"Delete server" button doesn't show properly on macOS
softins opened this issue · comments
Describe the bug
The "Delete server" button that was added in #3159 doesn't show properly on macOS. At least on my Mac running Catalina 10.15. The button is there, but it is too narrow to show the whole icon.
The button acts correctly when clicked on.
To Reproduce
Download and install a recent build artefact, e.g. from https://github.com/jamulussoftware/jamulus/actions/runs/8031934048. In this case, I installed the Mac Legacy, which had been built with Qt 5.15.2
Expected behavior
The button should be wide enough to show the backspace icon.
Screenshots
Operating system
MacOS 10.15 Catalina
Version of Jamulus
3.10.0dev-dbd6e61
Additional context
The button shows correctly on Windows, and when compiled on my Raspberry Pi. I haven't been able to try a more recent MacOS or the non-legacy build.
That's bad. Does the same happen in the server where a comparable button is?
That's bad. Does the same happen in the server where a comparable button is?
I will look more closely. Checking the various dev versions I have installed, it seems the delete button in the connect dialog shows up ok with Qt 5.9.9, but is truncated as shown above with Qt 5.12 or Qt 5.15. However, in all three cases the delete buttons in the Server Options page show up fine. I'll have to see what the subtle differences are.
It appears ok in the artifact I downloaded from #3260. I'll check again once that has been merged and built with Qt 5.15.2.
This is with Linux Qt 6.7.1:
This is with Windows Qt 6.7.1:
Hmm... they're not identical. The button in the server is larger and the glyph in the client is bold... (And, of course, different fonts between Linux and Windows. Probably some of the styling is set by the OS theming...)
Hmm... they're not identical. The button in the server is larger and the glyph in the client is bold... (And, of course, different fonts between Linux and Windows. Probably some of the styling is set by the OS theming...)
Yes, the button in connectdlgbase.ui has a <bold>true</bold> in the font setting. We can make sure all is consistent in the PR to fix this issue.
I think we'll have to do something, so yeah. I'd like the PR asap, of course :)
If we've no MacOS developers, we may have to drop MacOS support...
Before we drop macOS support I'll get into macOS development.
There are very likely some MacOS developers among the WorldJam participants. I'll put out a call...
If we've no MacOS developers, we may have to drop MacOS support...
I can look at it after my holiday.