jamesls / fakeredis

Fake implementation of redis API (redis-py) for testing purposes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implement redis-py's .lock()

akshayjshah opened this issue · comments

fakeredis.FakeStrictRedis doesn't implement redis-py's .lock() method. Are you open to a pull request that uses the standard lib's threading.Lock to fake the same behavior?

(Of course, I'll follow the contribution guidelines :)

Hey there, is there a reason this was closed without comment? I'm actually in need of the same thing.

I found a workaround for my own use case; if there's some utility in a general solution, though, I'm happy to reopen and open a PR. Just waiting on @jamesls to weigh in.

Sorry for the delay. Definitely would be open to a PR that emulates redis-py's lock() method.

Okay - I definitely won't have time to look at this again for a few weeks, but I can pick it up in early July.

commented

This would be very helpful. Have you had time to look at this @akshayjshah?

As is probably obvious, I don't think I'm going to get to this (probably ever) - I've mostly stopped using Redis and fakredis. Up to @jamesls whether he'd like to close this issue, or whether it's worth keeping around.

+1 need this

Need this !!