jakiestfu / Medium.js

A tiny JavaScript library for making contenteditable beautiful (Like Medium's editor)

Home Page:http://jakiestfu.github.io/Medium.js/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

modifiers bold/underline/italic etc. only work on selections?

ktiedt opened this issue · comments

On your demo page, I was really confused why ctrl+b etc was not modifying any text I was typing... later I came back and tried to select text and try it that way... it appears to only work on selections, that seems like not the intended behavior for a supposed RTE?

Can you clarify which of the instances it did/didn't work on? Also, if you
run the unit tests (click the green check in your browsers) and let us know
which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com wrote:

On your demo page, I was really confused why ctrl+b etc was not modifying
any text I was typing... later I came back and tried to select text and try
it that way... it appears to only work on selections, that seems like not
the intended behavior for a supposed RTE?


Reply to this email directly or view it on GitHub
#183.

Robert Plummer

In any rich demo... No keyboard shortcuts worked in latest chrome excep
unless you selected text first so General typing... It would fail. I'll see
about running tests at work tomorrow
On Feb 8, 2016 17:14, "Robert Plummer" notifications@github.com wrote:

Can you clarify which of the instances it did/didn't work on? Also, if you
run the unit tests (click the green check in your browsers) and let us know
which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com
wrote:

On your demo page, I was really confused why ctrl+b etc was not modifying
any text I was typing... later I came back and tried to select text and
try
it that way... it appears to only work on selections, that seems like not
the intended behavior for a supposed RTE?


Reply to this email directly or view it on GitHub
#183.

Robert Plummer


Reply to this email directly or view it on GitHub
#183 (comment)
.

Awesome for finding it. I will look at it as soon as I have a chance.

On Mon, Feb 8, 2016 at 8:19 PM, Karl Tiedt notifications@github.com wrote:

In any rich demo... No keyboard shortcuts worked in latest chrome excep
unless you selected text first so General typing... It would fail. I'll see
about running tests at work tomorrow
On Feb 8, 2016 17:14, "Robert Plummer" notifications@github.com wrote:

Can you clarify which of the instances it did/didn't work on? Also, if
you
run the unit tests (click the green check in your browsers) and let us
know
which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com
wrote:

On your demo page, I was really confused why ctrl+b etc was not
modifying
any text I was typing... later I came back and tried to select text and
try
it that way... it appears to only work on selections, that seems like
not
the intended behavior for a supposed RTE?


Reply to this email directly or view it on GitHub
#183.

Robert Plummer


Reply to this email directly or view it on GitHub
<
https://github.com/jakiestfu/Medium.js/issues/183#issuecomment-181655434>
.


Reply to this email directly or view it on GitHub
#183 (comment)
.

Robert Plummer