jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform

Home Page:https://www.jaegertracing.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[jaeger-v2] Do away with storage.ArchiveFactory

yurishkuro opened this issue · comments

Per comment https://github.com/jaegertracing/jaeger/pull/5152/files#r1501916983

We need to get rid of storage.ArchiveFactory interface because it is conceptually meaningless - archive storage is just a storage that implements SpanStorage interface. It should be the same thing with Factory, just have a storage.Factory that in context can be interpreted as primary or archive. We unnecessarily bundle these two.

I would like to work on this.

Can I work on this issue?

I am gonna close this as I don't think it's necessary given how v2 storage is evolving. @james-ryans is working on defining a new storage APIs for v2 where there won't be archive storage as an explicit interface.