jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform

Home Page:https://www.jaegertracing.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extract archive storage integration test from ES and generalize to all storage backends

yurishkuro opened this issue · comments

I just noticed, to my surprise, that archiving test is only implemented in the ES integration tests

func (s *ESStorageIntegration) testArchiveTrace(t *testing.T) {

Objective

  • Extract this test into the shared test suite
  • Make sure it works with the backends that support archiving (which may be all of them at this point)

Should I create a new test file under integration itself, to test archiving for all Backends? Or can I just add the tests to the pre-existing test files for each storage?

we already have integration.go as the shared framework for all backends, it should go there

Understood...
Thanks for clarification