Giters

jacobwb / hashover

Free and Open Source PHP Comment System

Home Page:http://tildehash.com/?page=hashover

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some image paths are hardcoded to assume the root directory to be /hashover/

dueringa opened this issue · comments

commented

I would like to put hashover under a different root directory.
There is a setting $root_dir in hashover/scripts/settings.php, line 26.

However, the following image paths are hardcoded:

hashover/comments.css:185:	background-image: url('/hashover/images/name.png');
hashover/comments.css:189:	background-image: url('/hashover/images/password.png');
hashover/comments.css:194:	background-image: url('/hashover/images/login.png');
hashover/comments.css:200:	background-image: url('/hashover/images/email.png');
hashover/comments.css:204:	background-image: url('/hashover/images/website.png');
hashover/comments.css:252:	background-image: url('/hashover/images/liked.png');
hashover/comments.css:257:	background-image: url('/hashover/images/like.png');
hashover/comments.css:262:	background-image: url('/hashover/images/like.png');
hashover/comments.css:266:	background-image: url('/hashover/images/liked.png');
hashover/comments.css:270:	background-image: url('/hashover/images/edit.png');
hashover/comments.css:274:	background-image: url('/hashover/images/has-email.png');
hashover/comments.css:278:	background-image: url('/hashover/images/no-email.png');
hashover/comments.css:522:	background-image: url('/hashover/images/bubble-tick.png');
hashover/comments.css:530:	background-image: url('/hashover/images/bubble-tick-reply.png');
hashover/scripts/javascript-mode.php:523:		echo jsAddSlashes('<span class="cmtnumber"><img width="' . $icon_size . '" height="' . $icon_size . '" src="/hashover/images/first-comment.png"></span>\n');
hashover/scripts/php-mode.php:316:		echo "\t\t" . '<span class="cmtnumber"><img width="' . $icon_size . '" height="' . $icon_size . '" src="/hashover/images/first-comment.png"></span>' . PHP_EOL;

It might be possible to fix this in both php files.
But I guess for the CSS files, I'm out of luck?

commented

Thanks for pointing this out. This should now be fixed. Relative paths in CSS files are relative to the directory they are stored in, so the CSS should now work under a different directory.

Please let me know if it doesn't work, and I'll fix any remaining path issues.