Support for vertical divider?

Question

Support for vertical divider?

vjustov opened this issue 6 years ago · comments

Viktor Justo V. commented 6 years ago

is it planned to enable also comparing the images vertically?

Jacob Parker · Answer 1 · Mon Feb 26 2018 01:57:13 GMT+0800 (China Standard Time)

I'd accept a PR for this

Viktor Justo V. · Answer 2 · Mon Feb 26 2018 03:09:34 GMT+0800 (China Standard Time)

I could take a stab at it. Could you give me some guidance, of where to start and how to approach it?

…

On Sun, Feb 25, 2018, 6:57 PM Jacob Parker ***@***.***> wrote: I'd accept a PR for this — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEIcKoj7Noots069ItIULyvwoETtHi3Rks5tYZ76gaJpZM4SSXwE> .

Jacob Parker · Answer 3 · Mon Feb 26 2018 19:46:44 GMT+0800 (China Standard Time)

It's pretty much just changing whether we use left or right in the positions of the elements to top or bottom. You'll then need to make the touch and mouse events handle vertical directions.

Let me know if any parts don't make sense