jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TimerWatchers not working under Windows

toptensoftware opened this issue · comments

Seems TimerWatchers don't work under Windows. Issues found:

  1. TimerWatcher.Start() is never called meaning the System.Threading.Timer never fires
  2. System.Threading.Timer callbacks can be re-entrant
  3. Multiple timer events can be queued causing single shot timers to fire multiple times.

Here's the fixes I made:

toptensoftware@3acdcc0

Thank you, I will take a look at your changes as soon as possible.

Should be fixed now.

Found another problem here where the System.Threading.Timer continues to run silently in the background. Fix is available in my current pull request or here:

toptensoftware@4ef3df5

Thank you, I'll apply that one too.