jackellenberger / emojme

:rotating_light: very powerful very stupid Slack emoji tools, holy cow! :rotating_light:

Home Page:https://jackellenberger.github.io/emojme

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rate limiting backoff messages inculde entire buffer data

jackellenberger opened this issue · comments

When rate limiting is detected we output message: Endpoint $endpoint rate limited. Will retry request $request after $time backoff, which is nice! But,

  • rate limiting shouldn't happen if we come in under the limit, which we should be
    • i think we need to increase the rate limit time to be suggested time * concurrent requests to account for the fact that slack is gonna punish us for having multiple concurrent requests hitting at the same time
  • $endpoint is undefined
  • $time is in ms but it says "seconds"
  • $request contains the entire image buffer for the emoji being rate limited, so the output becomes unreadable.

Resolved by a2875ea v1.6.2