Extending `PersistentState` is not safe
jac3km4 opened this issue · comments
jekky commented
- save files with custom data from
PersistentState
can't be loaded after removing the change - consider disallowing extending the
PersistentState
class
Pavel Siberx commented
just in case: this only applies to persistent
properties, but there is no issue with extending methods and other properties
Alastair Cota commented
Even without the PersistentState class there is persistent caching behaviour which makes this mod high risk due to difficulty of uninstallation without breaking other mods. I have recently had to verify integrity on Steam because redscripts have persisted in cache when the scripts have been disabled and written out. There is additionally no way to see the tree to prune it for the methods to remove and re-wrapping methods does not work. As it stands this is causing serious impact to related platforms.