jaanga / jaanga.github.io

Home page for jaanga.github.io - your 3D happy place. Explore ways of demonstrating STEM topics with beginner level code. Provide many simple cookbook examples. Written in plain JavaScript. Three.js is the only dependency.

Home Page:http://jaanga.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

2016-06-13 ~ GitHub API Users Event R5

theo-armour opened this issue · comments

image

@paulmasson

GitHub API Users Events

2016-06-13 R5

  • Add Gists
  • Update the selUser.selectedIndex with any onHashChange event
  • Centered the content in window

@theo-armour another idea: linking to an entire repository for commit events is not so interesting. Have the name of the repository there but link to either the commit or the full document that was altered.

@paulmasson

link to either the commit or the full document that was altered.

Great suggestion. Thank you.

It's been committed. See:

GitHub API User Events R6

@theo-armour just noticed in reviewing my work of the last two hours that a push event with more than one commit only links to the first one. Any way around that?

@paulmasson

In GitHub desktop, go to 'Open in git Shell'

$ git add -vA .
$ git commit -am "message here"
$ git push

seems to commit everything

Also helpful there:

$ git status

@theo-armour since this came from one of your issues on Jaanga, I thought that would be enough context. I mean your API viewer only links to the first commit, not a list of all of them.

@paulmasson

since this came from one of your issues on Jaanga, I thought that would be enough context.

Kindly remember that GitHb issues arrive via email. Since there's little visible context. It's very easy to mis-judge the context. Here's what I saw:

image

The lesson I am learning on online support is to be specific as possible in the body of the message


I mean your API viewer only links to the first commit, not a list of all of them.

Could you identify a sample event from here:

https://jaanga.github.io/cookbook-html/examples/github-api-rss/github-api-users-events/github-api-users-events-r6.html#PaulMasson

Just path and # will do

@theo-armour how about this one:

PushEvent
5. 01:56:46
Repository: paulmasson/three.js
Message: Add iOS workaround to MeshBasicMaterial - Size: 6 - Length: 6

@paulmasson

Can you supply a more appropriate URL for the link in this particular message? So I get a better idea of what you would like to see.

@theo-armour URL currently points to single commit of six total:

paulmasson/three.js@29cac1e

How about a drop-down list of commits when more than one with an appropriate title?

No rush on this. Since I've come to rely on this viewer, it's a feature I'd like to see.

Paul

URL currently points to single commit of six total:

I know this. I can click too, you know.

I am just looking for a sample of where it should link to...

Since I've come to rely on this viewer, it's a feature I'd like to see.

Me too. And working on aspects of User right now

On Sun, Jul 3, 2016 at 8:07 PM Paul Masson notifications@github.com wrote:

@theo-armour https://github.com/theo-armour URL currently points to
single commit of six total:

paulmasson/three.js@29cac1e
paulmasson/three.js@29cac1e

How about a drop-down list of commits when more than one with an
appropriate title?

No rush on this. Since I've come to rely on this viewer, it's a feature
I'd like to see.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAhbKpo1LUTKL8pPYPtmt-fNvVU_-Hl_ks5qSHj_gaJpZM4I0HfH
.

BTW, here is the current work on events

https://jaanga.github.io/cookbook-html/examples/github-api-rss/github-api-events/github-api-events-r2.html

You will notice that 'actor' is identified. Also more events are covered - and in a simpler manner.

The issue you bring up is a WIP.