napalm-procurve does not work with napalm 2.5
mnhauke opened this issue · comments
Napalm added MTU support for "get_interfaces" in their latest release napalm 2.5
This issue can be easily triggered by running napalm-procurve's unit tests against napalm 2.5.0
Here a logfile with the output from napalm-procurve's failed unit tests:
napalm-procurve-broken-build-napalm25-buildlog-openSUSE-tumbleweed.txt
Thanks for that report.
I did a quick fix in 2b1a6af. This works on my hardware but I have not run the full testsuite unter napalm 2.5 as I need to run out.
Please see if this fixes your issue and report back. Thank you.
2b1a6af seems to fix the MTU issue but running the full testsuite still gives some errors:
napalm-procurve-still-broken-build-napalm25-buildlog-openSUSE-tumbleweed.txt
@mnhauke hmmm. I think that was already covered.
There's a new 0.5.0 release, check if that one works for you.
bb49b52 fixes the issue. Thanks!
As far as I can see napalm-procurve 0.5.0 is working fine with napalm 2.5.0 now.
A quick test against napalm 2.4.0 shows that at least not all unit tests with this older version of napalm will pass but I'm not sure if it's worth to do the change in a backwards compatible way.
@mnhauke As far as I can see, the unit test fails because the expected return values changed between 2.4.0 and 2.5.0.
I would not even know how to change the returns accordingly depending on version...
So thanks for the report, 0.5.0 with 2.5.0 is the way to go then.