Provide a remove function, that kills the whole subtree

Question

Drakulix opened this issue 8 years ago · comments

I think a remove function that recursively removes all children should also be provided as well.

Ian Burns · Answer 1 · Fri Dec 16 2016 01:13:52 GMT+0800 (China Standard Time)

I agree. I remember thinking about including this originally as well, but I can't remember why I didn't do it.

I don't mind taking this one, but if you want it feel free to go for it.

Victoria Brekenfeld · Answer 2 · Fri Dec 16 2016 01:29:08 GMT+0800 (China Standard Time)

I would eventually do it, but I am not sure when.

Ian Burns · Answer 3 · Fri Dec 16 2016 01:30:04 GMT+0800 (China Standard Time)

In that case, pick it up if/when you have time, but otherwise I'll get to it when I can. No pressure to pick this one up if you don't feel like it.

Ian Burns · Answer 4 · Wed Dec 21 2016 03:56:30 GMT+0800 (China Standard Time)

@Drakulix I'm good to close this since #10 has merged correct? Just making sure there's nothing here that I'm missing.

Victoria Brekenfeld · Answer 5 · Wed Dec 21 2016 04:05:58 GMT+0800 (China Standard Time)

Yes. I just forgot to mark the PR as fixing this.