iwanders / OBD9141

A class to read an ISO 9141-2 port found in OBD-II ports.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

why using digitalwrite(tx_pin,true)

TeensyDucM opened this issue · comments

hi,

thank's you for your project.

i contact you because in your code, you uses a lot about the kline functin by passing true or false.

If you remain, the kline function are described like that

kline(bool enabled){
digitalWrite(this->tx_pin, enabled);
}

or in the arduino specification, digitalWrite function wait about HIGH or LOW.

Can you explain me this ?

However, do you think this library are compatible with fiat implementation of the Kline protocol ( ISO14230 layout 4) i can provide you the specification about the headers.

thank's

I'm not sure I 100% understand the question, but HIGH and LOW are just defines to true and false. In the function I use enabled as a variable. If enabled is true, it is equivalent to HIGH, if enabled is false it's equal to LOW. I hope this explains how the kline(bool enabled) function works.

Kline protocol ( ISO14230 layout 4)

I honestly don't know, I don't know what the difference is between layout 2 and layout 4. I expect modifications are necessary, but I don't know how many or how much work it would be. I don't have access to a car that does layout 4, so I would have no way to test changes.