ROR - Recipes app
zkr024 opened this issue · comments
- An app based on rails to create food recipes
Food list
Public recipes
Private recipes
login/registration functionality.
Project link : https://github.com/users/ivaan1992/projects/3
- The team project is composed of 2:
Hi @ivaan1992,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
The issue is good in detail ✅.
Required Changes ♻️
Check the comments under the review.
- Nice work on adding the Kanban cards but the cards should be having points attributed also.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Changes requested were applied.
click here
Hi @team,
Status: Approved ✔️
Good job adding the points and distributing the task fairly 👍 Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.