itzg / mc-router

Routes Minecraft client connections to backend servers based upon the requested server address

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Docker Swarm Support planend

LukasL28 opened this issue · comments

commented

To explain, I am running a docker swarm cluster, using the mc routuer works as intended, but I have a suggestion. Could you add dynamic support like with kubernetes but with docker labels (like traefik does ist). so you set a label called "mc-router=enabled" and "mc-router=example.domain@example.com" and now its routs the traffic of the container where the labels are set.

Yes this makes sense to have equivalent/similar support for plain Docker and Swarm deployments. I'll get this queued up.

Thanks for supporting docker swarm. If it's not too much trouble can you make this work with non-swarm deployments?

I could do it myself but I can't tell when I'll have time to work on it.

@Foxite I'm actually thinking this will work with non-swarm since the same API for getting container labels exists still.

That's what I thought, but right now when I start mc-router in docker swarm mode, it fails to start because "Error response from daemon: This node is not a swarm manager"

Thanks for double checking. Can you create a new enhancement issue and link it here?