itzg / mc-router

Routes Minecraft client connections to backend servers based upon the requested server address

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing doc for kube-discovery (or remove, if unused?)

vorburger opened this issue · comments

What does the kube-discovery config do?

It's mentioned in the README, but not used in the Kubernetes example.

https://github.com/itzg/mc-router/search?q=kube-discovery does not show it actually being used in source code. Is it perhaps something left over that could be removed from the README?

https://github.com/itzg/mc-router/search?q=KubeDiscovery shows the flag exists in code, but that then isn't read anywhere.

Would a PR to rm this from both README and main.go be welcome?

Or am I just missing where it's used?

Wow, yeah that indeed seems to be a dead option I was pondering before --in-kube-cluster. Yes, a PR would be great.