I upgraded your Hash_Mapper to work with latest ActiveSupport
jakeonrails opened this issue · comments
Hi,
You can see it here:
https://github.com/jakeonrails/mappity
I didn't do a fork because I just wanted to quickly fix it so I can play with it in my Rails 3.0+ app, I copied your lib and specs into a new project w/ Rspec and bundler, and have it now working with latest ActiveSupport.
Now that I know what to do, I can make a proper fork and submit a pull request to have an updated Hash_Mapper, or if you are not interested in this project any more I will release it as a new gem called Mappity.
Please let me know, I would rather just use the existing gem and just update it instead of making a new one.
By the way, nice work. This is a cool tool.
Thanks,
Hi Jake
I would love a pull request!
A number of people use this gem in existing projects (I myself do on a 3 years-old, still running ActiveSupport 2 project) and some others have contributed important performance fixes to it. It would be a shame to dilute the effort into a separate gem instead of improving the existing one.
Obviously I'd include you in the authors list.
May I ask what are you using it for?
Thanks you!
Ismael Celis
Web Developer at new-bamboo.co.uk
Founder at bootic.net
Twitter: @ismasan
On Friday, 10 February 2012 at 01:52, Jake Moffatt wrote:
Hi,
You can see it here:
https://github.com/jakeonrails/mappityI didn't do a fork because I just wanted to quickly fix it so I can play with it in my Rails 3.0+ app, I copied your lib and specs into a new project w/ Rspec and bundler, and have it now working with latest ActiveSupport.
Now that I know what to do, I can make a proper fork and submit a pull request to have an updated Hash_Mapper, or if you are not interested in this project any more I will release it as a new gem called Mappity.
Please let me know, I would rather just use the existing gem and just update it instead of making a new one.
By the way, nice work. This is a cool tool.
Thanks,
Reply to this email directly or view it on GitHub:
#3
I haven't even started using it, :) I was about to build something similar though, to handle mapping of data from feeds parsed from different sources into one normalized format. The idea is to take the xml/csv/raw data and map it to keys in a hash, then use the hash mapper to convert to a normalized hash, which can then be converted into a database record.
I'll make the changes I described - how do you feel about using bundler on the gem?
Cool! That's pretty much how we were using it when we wrote the first version.
Re. Bundler: oh yes please, Thanks!
Ismael Celis
Web Developer at new-bamboo.co.uk
On 10 Feb 2012, at 22:47, Jake Moffatt
reply@reply.github.com
wrote:
I haven't even started using it, :) I was about to build something similar though, to handle mapping of data from feeds parsed from different sources into one normalized format. The idea is to take the xml/csv/raw data and map it to keys in a hash, then use the hash mapper to convert to a normalized hash, which can then be converted into a database record.
I'll make the changes I described - how do you feel about using bundler on the gem?
Reply to this email directly or view it on GitHub:
#3 (comment)
Pull request here:
#4