isi-vista / adam

Abduction to Demonstrate an Articulate Machine

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Refactor PerceptionGraph's _to_dot_graph chain to use node methods

lichtefeld opened this issue · comments

No change needed, but this nested function confuses me. I thought we had a method on the nodes to compute the node label, so I'm sort of confused why we have this if-elif ladder.

Originally posted by @spigo900 in #1133 (comment)

Located: https://github.com/isi-vista/adam/blob/master/adam/perception/perception_graph.py#L561

Nodes define a method to generate a label for a dot graph so its unclear why this elif ladder still exists.