isadorasophia / murder

Murder is a pixel art ECS game engine.

Home Page:https://isadorasophia.com/murder/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Index outside bounds crash when editing TileGridComponent

slinaresperalta opened this issue · comments

Summary:

When you try to edit the width or height of a TileGridComponent in the world view out of its bounds, it crash the editor.

What should happen:

It should not allow to go out of bounds, without crashing.

How to reproduce the issue:

https://github.com/isadorasophia/hellomurder/assets/94173512/8c382636-d84a-4f68-a7a1-f42fddd0fc19
https://github.com/isadorasophia/hellomurder/assets/94173512/33866940-cb0f-4085-8d88-7c2c280dc79f
https://github.com/isadorasophia/hellomurder/assets/94173512/fea96988-b3d4-4414-becd-90800d17ca99

Fixed by 2d073c4
These numbers shouldn't be exposed to the editor, since we need to internally resize the grid everytime they change. To fix this disabled the editing capabilities for the TileGridComponent and added a shortcut to the correct place, the tiles editor tab.
image