isaacplmann / ngx-tour

Product Tour Built in Angular

Home Page:https://isaacplmann.github.io/ngx-tour

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Any plans for angular 9 upgrade?

pnaika opened this issue · comments

Thank you for this amazing lib, any plans to upgrade the project to angular 9. Thanks

Are there any actual errors when trying the library in an Angular 9 app? The recommendation from the Angular team is to keep libraries compiled with the View Engine renderer until Angular 10.

I think all that is needed is to bump the peerDependency requirements in the app to not throw a warning during npm install.

Please post any actual errors you run into when upgrading.

After building in production mode a library that is using Angular v9, when trying to start an application that depends on this library, I am getting the following error:

ERROR in ./lib/lacuna-spa/__ivy_ngcc__/fesm2015/lacuna-spa.js 7880:108-131
"export 'NgxmTourService' (imported as 'ɵngcc25') was not found in 'ngx-tour-md-menu'

This error only happens when my library is using Angular v9 (it does not happen in versions 7 and 8). It looks like Angular v9 is transforming the reference to "TourService" from 'ngx-tour-md-menu' to NgxmTourService again, even though this service is exported as TourService in public_api.ts, and, because of that, it cannot resolve this reference again when compiling/starting the application.

Apparently, other packages are going through the same problem, as you can see here.