iridakos / goto

Alias and navigate to directories with tab completion in Linux

Home Page:https://iridakos.com/programming/2019/04/10/shell-navigation-with-autocomplete

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ZSH _complete_goto_aliases autocomplete error

TheOffender opened this issue · comments

OSX 10.11

bash --version

GNU bash, version 4.4.19(1)-release (x86_64-apple-darwin15.6.0)

zsh --version

zsh 5.0.8 (x86_64-apple-darwin15.0)

When using bash, works great. When using ZSH, however, it returns the error. I can register and list entries, and can manually type the whole registered alias. When tab completing registered aliases, it returns the following error:

~ goto -l
git /Users/'username'/GIT
~ goto _complete_goto_aliases:local:4: not valid in this context: git /Users/'username'/GIT)
_complete_goto_aliases:local:4: not valid in this context: git /Users/'username'/GIT)
_complete_goto_aliases:local:4: not valid in this context: git /Users/'username'/GIT)
goto

I know that ZSH substitution is different than bash, but haven't been able to pin down exactly what part of the _complete_goto_aliases function is not substituting correctly

Great tool!

Thanks for reporting! I will also add an item to test in zsh also in the TODO section of the README file.

FYI - had to enable bash completion script compatibility mode to handle the 'compete' command for me.

autoload bashcompinit                                                                                                                                                                                    
bashcompinit

Having a similar issue with tab completion in ZSH with partial completions
zsh 5.0.2 (x86_64-pc-linux-gnu)

goto d
_complete_goto_aliases:13: bad substitution

Agree -- very helpful!

@caanaan Thank you! I will try to fix that even though I'm not that familiar with zsh 🤞

trying to autocomplete a wrong word using zsh version 5.4.2 (x86_64-pc-linux-gnu)
image

From a quick look at zsh, I get the feeling that the script has to be re-written for zsh in its own file since the completion mechanism is very different from Bash's. git does the same for its completion scripts.

It won't happen soon, at least by me cause I have to familiarize myself with zsh first.

Adding the help wanted label.

Completion now is supported!

@jshort Just checked the functionality on zsh and it's great 👍 👍 👍