Giters

iree-org / iree

A retargetable MLIR-based machine learning compiler and runtime toolkit.

Home Page:http://iree.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cleanup in preprocessing dir

IanWood1 opened this issue · comments

commented 
          nit: already in the `iree_compiler` namespace, can simplify this?

    : public Preprocessing::impl::ApplyPDLLPatternsPassBase<

I see a bunch of these public iree_compiler:: in the Preprocessing/ folder, could clean those up too (in a separate PR to keep this one focused)

Originally posted by ScottTodd in #17144 (comment)

commented

Would be good cleanup! The style we hold is that iree_compiler can be omitted because all IREE code is in it, and then any dialect references require explicit specification (so "IREE::Flow::TensorReshapeOp", not "iree_compiler::IREE::Flow::TensorReshapeOp", "Flow::TensorReshapeOp", any using namespace of IREE-prefixed namespaces, etc). I've been trying to clean some of these up as I find them but more help would be appreciated!