OpWithOffsetSizesAndStrides with only leading offset/sizes/strides overflow.
nicolasvasilache opened this issue · comments
See: https://reviews.llvm.org/D108617
Note, all OpWithOffsetSizesAndStrides may take only a subset of
leading values (and auto complete the remaining ones to the canonical expected offsets/sizes/strides); as a consequence this may overflow.
Sending a bugfix for this but FYI there may be other occurrences.
One easy way to track them down could be to force the verifier to specify everything and run tests (but that will catch false rank-reducing positives; still it should help).
@springerm if you get to it first.
Wasnt very hard to fix actually. https://reviews.llvm.org/D115677
Note my comment on the tensor versions; those ones are also blocking me to get the e2e parallel stuff working.
Ok, I am looking at that too. Will update the patch.
Updated the patch removing the issues with tensor.s as well. No failures in core. If you have a failure somewhere let me know.