ipfs / go-verifcid

Temporary repo to provide cid security code prior to it getting merged into go-cid

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add BLAKE3 to allowed list

markg85 opened this issue · comments

Hi,

multiformats/go-multihash#121 (comment) added support for BLAKE3.
Currently this is technically available in go-ipfs 0.11.

However, because BLAKE3 isn't in the list of allowed hashes one gets Error: potentially insecure hash functions not allowed
That is with a IPFS command line like:
ipfs add --nocopy --hash blake3 <somefile>

Could BLAKE3 be allowed too?

Best regards,
Mark

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

Awesome! Thank you for the pointer.
I'm not quite sure if this issue needs to be closed now..? It looks like it kinda depends on how it's going to be solved in ipfs/kubo#8650 If a --force option would allow it then this issue would essentially be a non-issue.

Adding an upvote to this issue :) our project would love if IPFS/multihash supported blake3. Would make our infrastructure much easier to build.

Done in #16 !