Option.get analyzer

Question

Option.get analyzer

sheridanchris opened this issue 7 months ago · comments

Christian Sheridan commented 7 months ago

I think an analyzer for Option.get that promotes the graceful handling of the None case by using functions like Option.defaultValue or pattern matching should be added. I'd like to create a PR for this if you believe this is a useful addition.

Florian Verdonck · Answer 1 · Wed Nov 15 2023 20:03:05 GMT+0800 (China Standard Time)

Hi Chris,

Thank you for this suggestion! We like it and would be happy to receive a PR for this 🥳!
Don't hesitate to ask any technical questions if you have any.

dawe · Answer 2 · Wed Nov 15 2023 20:44:51 GMT+0800 (China Standard Time)

This sample could be of help for you to get started:
https://github.com/ionide/FSharp.Analyzers.SDK/blob/master/samples/OptionAnalyzer/Library.fs

Richard Webb · Answer 3 · Wed Nov 15 2023 21:38:13 GMT+0800 (China Standard Time)

could / should there be something similar for ValueOption ?

Florian Verdonck · Answer 4 · Wed Nov 15 2023 21:42:45 GMT+0800 (China Standard Time)

Yeah, seems reasonable. Are you interested in submitting a PR?

Florian Verdonck · Answer 5 · Wed Nov 15 2023 21:43:35 GMT+0800 (China Standard Time)

Would probably be nothing more than adding an OR in if mfv.FullName = "Microsoft.FSharp.Core.Option.get" && args.Length = 1 then

Richard Webb · Answer 6 · Wed Nov 15 2023 21:52:39 GMT+0800 (China Standard Time)

I can have a go later if no one else gets to it first

dawe · Answer 7 · Wed Nov 15 2023 21:54:08 GMT+0800 (China Standard Time)

I think we should have the Option.Value analyzer from the SDK sample as well.