ionic-team / ionic-starter-super

The Ionic 2 Super Starter 🎮

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace image item

agustin-rr opened this issue · comments

Hello everyone,

congratulations for this template, it's great!!

I have found a bug at Item Create Page (/src/pages/item-create/item-create.ts). If you add a image and then you want change it press over the picture again. You get the runtime error:

Cannot read property 'removeChild' of null

Why remove the file input in processWebImage() method?

Thanks,

Hi,

I have the same problem here. I see no sense to remove the file input in processWebImage() method in: input.parentNode.removeChild(input);

Is there any reason why that is removed?

If anyone knows about it, it would be great if he/she could share it with us.

(EDIT: @wbhob Sorry if it bothers you to mention you here, but I've seen you know your stuff about this. Could you clarify it, please?)

Thanks :)

I agree, it should just be *ngIf'd out IMHO, otherwise it will be completely removed from the DOM and not salvageable.

@agustin-rr fixed with the next release. Thank you