setup.spec and package.spec tests failing (Windows and Ubuntu)

[jakub-g]

I had the same failures both on Windows and Ubuntu, both on Node 0.12.10 and 4.3.1

(in addition to the ones reported on #32)

Are they working fine for you?

Failures:                                                                                                              

  1) Package should get 202 and message from package service                                                           
   Message:                                                                                                            
     Expected 'this' to be 'TypeError: Cannot read property 'noresources' of undefined                                 
    at c:\git\ionic-app-lib\lib\package.js:207:25                                                                      
    at _fulfilled (c:\git\ionic-app-lib\node_modules\q\q.js:787:54)                                                    
    at self.promiseDispatch.done (c:\git\ionic-app-lib\node_modules\q\q.js:816:30)                                     
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:749:13)                               
    at c:\git\ionic-app-lib\node_modules\q\q.js:557:44                                                                 
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)                                                         
    at process._tickCallback (node.js:355:11)'.                                                                        
   Stacktrace:                                                                                                         
     Error: Expected 'this' to be 'TypeError: Cannot read property 'noresources' of undefined                          
    at c:\git\ionic-app-lib\lib\package.js:207:25                                                                      
    at _fulfilled (c:\git\ionic-app-lib\node_modules\q\q.js:787:54)                                                    
    at self.promiseDispatch.done (c:\git\ionic-app-lib\node_modules\q\q.js:816:30)                                     
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:749:13)                               
    at c:\git\ionic-app-lib\node_modules\q\q.js:557:44                                                                 
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)                                                         
    at process._tickCallback (node.js:355:11)'.                                                                        
    at c:\git\ionic-app-lib\spec\package.spec.js:96:24                                                                 
    at _rejected (c:\git\ionic-app-lib\node_modules\q\q.js:797:24)                                                     
    at c:\git\ionic-app-lib\node_modules\q\q.js:823:30                                                                 
    at Promise.when (c:\git\ionic-app-lib\node_modules\q\q.js:1035:31)                                                 
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:741:41)                               
    at c:\git\ionic-app-lib\node_modules\q\q.js:557:44                                                                 
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)                                                         
    at process._tickCallback (node.js:355:11)                                                                          

...

  3) Setup should set up sass correctly
   Message:
     Expected spy npmInstall to have been called with [ '/some/ionic/app' ] but it was never called.
   Stacktrace:
     Error: Expected spy npmInstall to have been called with [ '/some/ionic/app' ] but it was never called.
    at c:\git\ionic-app-lib\spec\setup.spec.js:25:32
    at _fulfilled (c:\git\ionic-app-lib\node_modules\q\q.js:787:54)
    at self.promiseDispatch.done (c:\git\ionic-app-lib\node_modules\q\q.js:816:30)
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:749:13)
    at c:\git\ionic-app-lib\node_modules\q\q.js:509:49
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)
    at process._tickCallback (node.js:355:11)

  4) Setup should set up sass correctly
   Message:
     Expected spy modifyIndexFile to have been called with [ '/some/ionic/app' ] but it was never called.
   Stacktrace:
     Error: Expected spy modifyIndexFile to have been called with [ '/some/ionic/app' ] but it was never called.
    at c:\git\ionic-app-lib\spec\setup.spec.js:26:37
    at _fulfilled (c:\git\ionic-app-lib\node_modules\q\q.js:787:54)
    at self.promiseDispatch.done (c:\git\ionic-app-lib\node_modules\q\q.js:816:30)
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:749:13)
    at c:\git\ionic-app-lib\node_modules\q\q.js:509:49
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)
    at process._tickCallback (node.js:355:11)

  5) Setup should set up sass correctly
   Message:
     Expected spy buildSass to have been called with [ '/some/ionic/app' ] but it was never called.
   Stacktrace:
     Error: Expected spy buildSass to have been called with [ '/some/ionic/app' ] but it was never called.
    at c:\git\ionic-app-lib\spec\setup.spec.js:27:31
    at _fulfilled (c:\git\ionic-app-lib\node_modules\q\q.js:787:54)
    at self.promiseDispatch.done (c:\git\ionic-app-lib\node_modules\q\q.js:816:30)
    at Promise.promise.promiseDispatch (c:\git\ionic-app-lib\node_modules\q\q.js:749:13)
    at c:\git\ionic-app-lib\node_modules\q\q.js:509:49
    at flush (c:\git\ionic-app-lib\node_modules\q\q.js:108:17)
    at process._tickCallback (node.js:355:11)

[jakub-g]

@dwieeb i did a git bisect, the first failure is a recent regression after 7b69fd6

the failure about the sass is more tricky, when I tried to backtrack it via 0.6.0, 0.5.0... doing npm install; npm test and then going again towards master, it disappeared in master; it only reappeared after rimraf node_modules; npm install; npm test in master. Hopefully this is enough for you to figure it out.

[Josh Thomas]

This failing test was fixed in a recent pull request. If you care still having issues please feel free to open a new issue. Thanks!