build fails with current source

Question

build fails with current source

skochinsky opened this issue 6 years ago · comments

It may be that I fail at git but reporting this just in case. Using VS2015 but with Target Platform set to 10.0.10240.0 (not sure if important).

recent git pull cleaned up the openssl directory with the exeption of a few includes so BaseCryptLib and OpenSslLib fail to build due to missing .c files
GlueLib fails to compile guid.c due to last line:

1>------ Build started: Project: GlueLib, Configuration: Release x64 ------
1>  guid.c
1>guid.c(105): error C2065: 'EDKII_IFR_BIT_VARSTORE_GUID': undeclared identifier
1>guid.c(105): error C2099: initializer is not a constant

commenting it out allows build to succeed and I can build the samples.

Alex Ionescu · Answer 1 · Fri Nov 16 2018 04:45:18 GMT+0800 (China Standard Time)

You might have only done a shadow pull and still using an older edk2 upstream. Best regards, Alex Ionescu

…

On Thu, Nov 15, 2018 at 8:27 PM Igor Skochinsky ***@***.***> wrote: It may be that I fail at git but reporting this just in case. Using VS2015 but with Target Platform set to 10.0.10240.0 (not sure if important). 1. recent git pull cleaned up the openssl directory with the exeption of a few includes so BaseCryptLib and OpenSslLib fail to build due to missing .c files 2. GlueLib fails to compile guid.c due to last line: 1>------ Build started: Project: GlueLib, Configuration: Release x64 ------ 1> guid.c 1>guid.c(105): error C2065: 'EDKII_IFR_BIT_VARSTORE_GUID': undeclared identifier 1>guid.c(105): error C2099: initializer is not a constant commenting it out allows build to succeed and I can build the samples. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxIeEHYNzPV4camSnhmRuFxThW9--6xks5uvcApgaJpZM4Yh9U3> .

Igor Skochinsky · Answer 2 · Fri Nov 16 2018 19:05:41 GMT+0800 (China Standard Time)

Tried some git incantations but could not get it to work. Finally deleted everything and did a pull from scratch:

git clone https://github.com/ionescu007/VisualUefi.git --recurse-submodules

This seems to have worked - EDK-II compiled without errors and samples too. Got one minor warning though:

1>LINK : warning LNK4281: undesirable base address 0x0 for x64 image; set base address above 4GB for best ASLR optimization

Alex Ionescu · Answer 3 · Fri Nov 16 2018 19:15:05 GMT+0800 (China Standard Time)

Yep known annoying issue. If you find a compiler flag to make it go away, I’d appreciate a PR.

On Fri, Nov 16, 2018 at 12:05 PM Igor Skochinsky ***@***.***> wrote: Tried some git incantations but could not get it to work. Finally deleted everything and did a pull from scratch: git clone https://github.com/ionescu007/VisualUefi.git --recurse-submodules This seems to have worked - EDK-II compiled without errors and samples too. Got one minor warning though: 1>LINK : warning LNK4281: undesirable base address 0x0 for x64 image; set base address above 4GB for best ASLR optimization — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxIeLjAjFDBfp591QnQoRmJdc5c7fALks5uvpwGgaJpZM4Yh9U3> .

-- Best regards, Alex Ionescu

Igor Skochinsky · Answer 4 · Fri Nov 16 2018 21:06:18 GMT+0800 (China Standard Time)

I don't trust myself enough with git to make a PR, but /IGNORE:4281 in linker options seems to suppress it.

Matthijs Lavrijsen · Answer 5 · Fri Nov 30 2018 04:22:01 GMT+0800 (China Standard Time)

It does, and I've created a PR to add this flag to the linker options in your stead 😉