iommirocks / iommi

Your first pick for a django power cord

Home Page:http://iommi.rocks

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

radios problem with div{field.attrs} > div{field.attrs}

berycz opened this issue · comments

commented

when using Field.radio (or maybe later Field.checkboxes #405 ) it creates html structure like this

div{field.attrs}
    label
    div{field.attrs}  # 1. choice
        input
        label
    div{field.attrs}  # 2. choice
        input
        label
    ...

with bs5 you get double .form-check and thus double padding.

Imo there should be field.attrs vs. subfields.attrs.
I'm not sure if anyone will need attrs per choice, but at least a common attrs for all subfields would be nice, so people don't have to override templates.

another case may be when you need to use .form-check-inline

<div>
    <label />
    <div class="form-check form-check-inline">
        <input />
        <label />
    </div>
    ...
</div>