iobroker-community-adapters / ioBroker.synology

ioBroker SYNOLOGY Adapter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Future of possible stale syno.js base project / remove dependency to meisterTR github repo

mcm1957 opened this issue · comments

ioBroker.synology is based on syno.js, located at https://github.com/kwent/syno. This repo did not get real updates since a longer timeframe (last non dependa bot commit from Oct 2020, last commit not related to dependencies longer ago).

I've open an issue questioning whether a official support of DSM 7 is planned:
kwent/syno#72

This isse has not yet been answered / processed. In case syno.js is really dead we should discuss whether the code should be moved into ioBroker.synology all together and expanded to support DSM 7.

IMPORTANT:
As I just detected to package.json links the follwoing dependencies requesting syno direct form meisterTR github:

"syno": "git+https://github.com/MeisterTR/syno"

List of potential problems to be handled if a migration is considered:

a) kwent/syno seems to be written using coffee script (?). To be checked who could manage this or rewrite it using js.
b) kwent/syno uses "request" package (https://github.com/kwent/syno/blob/master/src/syno/Syno.coffee#:~:text=%23%20Require%20node,%27path%27) which is deprecated and no longer supported. Should be replaced by http/https packages or ev. better by complete axios support.

a) in fact download the npm package and you will have "compiled" javascript ... this could be a basis for a rewite and restructing, but yes gets then a bigger topic
b) Is just a "mid prio" issue ... yes if rewritten then can be exchanged, but still works fine

AttentioN.
According to package.json the syno module is loaded from meisterTR github (!)

  "dependencies": {
    "@iobroker/adapter-core": "^2.6.6",
    "moment": "^2.29.4",
    "simple-ssh": "^1.1.0",
    "syno": "git+https://github.com/MeisterTR/syno"
  },

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.