ssh errors logged with level "debug" instead of "error"

[Martin M.]

Describe the bug
Errors ocurring during ssh commands are not visible, they are logged with .debug level only.

synology.0	2022-09-30 17:42:03.905	warn	System reboot
synology.0	2022-09-30 17:42:03.900	debug	*** ERROR : src: SSH Error: code: undefined message: sudo: 1 incorrect password attempt
synology.0	2022-09-30 17:42:03.899	debug	*** ERROR : src: SSH Error: code: undefined message: sudo: no password was provided
synology.0	2022-09-30 17:42:03.898	debug	*** ERROR : src: SSH Error: code: undefined message: Sorry, try again.Password:

Expected behavior
I would expect to see above error with severity "error" (and not severiyt "debug".

Versions:

• Adapter version: synology 2.1.9

DSM is 7.1, Command was "reboot"

Note:
The "function error" is a little bit confusing - it looks like every error is output as debug log if output at all:

   if (!~src.indexOf('getSongCover')){
        adapter.log.debug(`*** ERROR : src: ${src || 'unknown'} code: ${code} message: ${message}`);
    }

[Martin M.]

The routine "fucntion error" is called by functions which regular raise errors, i.e. polling the audiostation at a system without such a package installed. So error handling must become smarter to ignore those errors (as it does now) but raise real errors such as ssh password errors etc.

Issue needs detailed analysis

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

[Martin M.]

Stil not solved