Self Updater fails to apply update but claims it was successful
dissentiate opened this issue · comments
Setup
- Version: 5.8.54
- Environment: ZIP
Interface
- Flutter: []
- React: []
- Both: [x]
Checklist
- Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? NO
- Have you searched existing issues? YES
- Have you reported this to Slack/forum before posting? NO
- Have you inspected the logs in storage/logs/laravel.log for any errors? YES Also monitored nginx access/error logs as well as well as separate /var/log/nginx/ininja.{access/error}.log
Describe the bug
Please see the Steps To Reproduce
Steps To Reproduce
See screencast below.
Screencast.from.2024-05-24.14-58-47.webm
Expected Behavior
Update applied as stated (successfully).
Additional context
I monitored the network tab in the dev tools of my browser (tested both on Firefox Developer Edition (latest) and on latest Chromium. There were no errors thrown on the response of the self-updater; everything returned a 200 response on both browsers.
Here is my nginx conf
`
server {
server_name my.install.com;
root /var/www/html/my.install.com/public;
add_header X-Frame-Options "SAMEORIGIN";
add_header X-Content-Type-Options "nosniff";
index index.php;
charset utf-8;
location / {
try_files $uri $uri/ /index.php?$query_string;
fastcgi_read_timeout 300s;
}
location = /favicon.ico { access_log off; log_not_found off; }
location = /robots.txt { access_log off; log_not_found off; }
access_log /var/log/nginx/ininja.access.log;
error_log /var/log/nginx/ininja.error.log;
error_page 404 /index.php;
location ~ \.php$ {
fastcgi_pass unix:/var/run/php/php8.3-fpm.sock;
#fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;
fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
fastcgi_intercept_errors off;
fastcgi_buffer_size 16k;
fastcgi_buffers 4 16k;
fastcgi_read_timeout 300s;
include fastcgi_params;
fastcgi_index index.php;
}
sendfile off;
location ~ /\.(?!well-known).* {
deny all;
}
listen [::]:443 ssl ipv6only=on; # managed by Certbot
listen 443 ssl; # managed by Certbot
ssl_certificate /etc/letsencrypt/live/my.install.com/fullchain.pem; # managed by Certbot
ssl_certificate_key /etc/letsencrypt/live/my.install.com/privkey.pem; # managed by Certbot
include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot
}
server {
if ($host = my.install.com) {
return 301 https://$host$request_uri;
} # managed by Certbot
listen 80;
listen [::]:80;
server_name my.install.com;
return 404; # managed by Certbot
}
`
Screenshots
Prior to update
After update
Logs
/var/www/html/invoiceninja/storage/logs/laravel.log
No errors or anything relevant recorded
/var/log/nginx/error.log
No errors recorded
/var/log/nginx/ininja.error.log
No errors recorded
/var/log/nginx/ininja.access.log
[24/May/2024:21:35:41 +0000] "POST /api/v1/self-update? HTTP/2.0" 200 50 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:44 +0000] "GET / HTTP/2.0" 200 1755 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:44 +0000] "GET /js/pdf.min.js HTTP/2.0" 200 54951 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:44 +0000] "GET /main.foss.dart.js?v=5.8.54 HTTP/2.0" 200 3580726 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:45 +0000] "GET /flutter_service_worker.js?v=5.8.54 HTTP/2.0" 200 9846 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:46 +0000] "GET /flutter_service_worker.js?v=5.8.54 HTTP/2.0" 304 0 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:49 +0000] "POST /api/v1/refresh?&first_load=true&include_static=true&einvoice=true HTTP/2.0" 200 100877 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:35:49 +0000] "POST /api/v1/refresh?&first_load=true&include_static=true&einvoice=true HTTP/2.0" 200 100877 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:38 +0000] "POST /api/v1/self-update? HTTP/2.0" 200 50 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:41 +0000] "GET / HTTP/2.0" 200 1755 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:41 +0000] "GET /js/pdf.min.js HTTP/2.0" 200 54951 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:41 +0000] "GET /main.foss.dart.js?v=5.8.54 HTTP/2.0" 200 3580726 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:42 +0000] "GET /flutter_service_worker.js?v=5.8.54 HTTP/2.0" 200 9846 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:44 +0000] "GET /flutter_service_worker.js?v=5.8.54 HTTP/2.0" 304 0 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:44 +0000] "POST /api/v1/refresh?&first_load=true&include_static=true&einvoice=true HTTP/2.0" 200 100877 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:44 +0000] "POST /api/v1/refresh?&first_load=true&include_static=true&einvoice=true HTTP/2.0" 200 100877 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"
[24/May/2024:21:38:45 +0000] "GET /storage/pLTQqLLluPZH25rE4dEVwC6GmoH2PfFg/jUE4ZJdR2whQsA0GNCIAT6HEq4Z4mL5q5gZqXqnU.png HTTP/2.0" 200 7462 "https://my.install.com" "Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0"